fix: split if-return chains in string-dispatch and type-system#137
Merged
Conversation
…o avoid if-drop bug
Owner
Author
|
Shouldn't we fix the root cause of the if drop on 5th if return block? Fix it or at the very least throw a fatal error from the compiler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dispatchStringMethod()(20+ consecutive if-returns) into 4 helper functions with ≤4 branches eachdispatchArrayMethod()(12+ consecutive if-returns) into 4 helper functions with ≤4 branches eachcanonicalTypeToLlvm()(11+ consecutive if-returns) into 5 helper functions with ≤4 branches eachMitigates the native compiler's if-drop bug (5th+ consecutive if-return blocks get silently dropped in Stage 0).
Test plan
npx tsc --noEmitpassesnpm run verify:quickpasses (self-hosting Stage 0 + Stage 1)